Skip to content

to-disk: Fix containers-storage prefix duplication #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Johan-Liebert1 merged 1 commit into from
Apr 29, 2026
Merged

to-disk: Fix containers-storage prefix duplication #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/kit/src/to_disk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,15 @@ pub enum RunOutcome {
///
/// Main entry point for the bootc installation process. See module-level documentation
/// for details on the installation workflow and architecture.
pub fn run(opts: ToDiskOpts) -> Result<RunOutcome> {
pub fn run(mut opts: ToDiskOpts) -> Result<RunOutcome> {
// Normalize the source image name by stripping containers-storage: prefix if present.
// The containers-storage: prefix is a transport specifier used by some tools like skopeo,
// but podman commands (image inspect, run --mount=type=image) expect just the image name.
// We'll add it back where needed (e.g., in bootc install commands).
if let Some(stripped) = opts.source_image.strip_prefix("containers-storage:") {
opts.source_image = stripped.to_string();
}

// Phase 0: Check for existing cached disk image
let would_reuse = if opts.target_disk.exists() {
debug!(
Expand Down
Loading