Skip to content

ephemeral run: Print hint when running in foreground #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgwalters merged 1 commit into from
May 1, 2026
Merged

ephemeral run: Print hint when running in foreground #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion crates/kit/src/run_ephemeral.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
//! - Ensures perfect fidelity of user options across process boundaries

use std::fs::File;
use std::io::{BufWriter, Seek, Write};
use std::io::{BufWriter, IsTerminal, Seek, Write};
use std::os::unix::process::CommandExt;
use std::process::{Command, Stdio};

Expand Down Expand Up @@ -404,6 +404,18 @@ pub fn run_detached(opts: RunEphemeralOpts) -> Result<String> {

/// Launch privileged container with QEMU+KVM for ephemeral VM.
pub fn run(opts: RunEphemeralOpts) -> Result<()> {
// Print helpful hint when running in foreground mode without console
if !opts.podman.detach && !opts.common.console && std::io::stderr().is_terminal() {
if let Some(name) = &opts.podman.name {
eprintln!(
Copy link
Copy Markdown
Collaborator

@cgwalters cgwalters May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit but I think in general for interacting with the user I would say we should just use println! or possibly indicatif.

"Hint: Use 'bcvk ephemeral ssh {}' to connect, or add --console to see VM output",
name
);
} else {
eprintln!("Hint: Add --console to see VM output, or use -d for background mode");
}
}

let (mut cmd, _temp_dir) = prepare_run_command_with_temp(opts)?;
// Keep _temp_dir alive until exec replaces our process
// At this point our process is replaced by `podman`, we are just a wrapper for creating
Expand Down
Loading