Add --virtiofsd CLI option and VIRTIOFSD_BIN env var support#266
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to explicitly specify the path to the virtiofsd binary via a new configuration option, a --virtiofsd CLI flag, and a VIRTIOFSD_BIN environment variable. This allows users to override the default auto-detection logic. The changes span the virtiofsd spawning logic in bcvk-qemu and the CLI argument handling in kit. Feedback suggests improving error handling by verifying the existence of the user-provided path immediately and addressing potential path resolution or accessibility issues when the binary is used within a containerized environment.
nickryand
force-pushed
the
push-kpxpkoswxpww
branch
from
c939cff to
2a50a76
Compare
|
Hi @nickryand there's some info here https://github.com/bootc-dev/bcvk/pull/266/checks?check_run_id=76126634878 on what you need to do for the DCO check. |
nickryand
force-pushed
the
push-kpxpkoswxpww
branch
from
194d514 to
945e218
Compare
Signed-off-by: Nick Downs <nickryand@gmail.com>
Signed-off-by: Nick Downs <nickryand@gmail.com>
nickryand
force-pushed
the
push-kpxpkoswxpww
branch
from
945e218 to
0fb84f0
Compare
|
Thanks @cgwalters. I signed the commits and rebased against upstream. |
|
Now needs a |
|
oof my bad. Should be complete. |
Update bcvk-qemu to the latest version. The VirtiofsConfig struct gained a virtiofsd_binary field in bootc-dev/bcvk#266 (f661aad), so update the struct literal in anaconda.rs accordingly. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: John Eckersberg <jeckersb@redhat.com>
2 participants
This should close out #265.