add support for key autoenroll to sdboot #1818
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gareth Widlansky <gareth.widlansky@proton.me> add autoenroll to sdboot Signed-off-by: Gareth Widlansky <gareth.widlansky@proton.me> asdf Signed-off-by: Gareth Widlansky <gareth.widlansky@proton.me>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for auto-enrolling Secure Boot keys for sd-boot from .auth files located in /usr/lib/bootc/keys within a composefs image. The changes look good overall. My review includes a suggestion to make the key discovery process more robust by handling cases where the keys directory does not exist, and a minor performance improvement to avoid an unnecessary allocation within a loop.
gerblesh
force-pushed
the
sdboot-autoenroll
branch
from
3c2bb96 to
d8a145d
Compare
added 4 commits
December 2, 2025 13:32
Signed-off-by: Gareth Widlansky <gareth.widlansky@proton.me>
Signed-off-by: Gareth Widlansky <gareth.widlansky@proton.me>
Signed-off-by: Gareth Widlansky <gareth.widlansky@proton.me>
Signed-off-by: Gareth Widlansky <gareth.widlansky@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add autoenroll to sdboot
installs
.authfiles from/usr/lib/bootc/keysintoESP/loader/keys/auto. Currently uses cfs file APIs and is a little rough. Not sure if this should be incomposefs-bootrather thanbootc. The directory/usr/lib/bootc/keysprobably isn't the best choice although at least it means that the auth files are "measured" when the cfs digest is taken.Note that this is missing some of the bits from CI for this to be properly tested. I will try to get that done when I can though