install: support configuring sysroot.bls-append-except-default #1909
+94
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for configuring sysroot.bls-append-except-default for ostree during installation. The changes are well-structured, introducing the necessary configuration options and the logic to apply them. The new functionality is also covered by a test case. I've provided a couple of suggestions to improve code readability and remove duplication.
jbtrystram
suggested changes
Jan 20, 2026
joelcapitao
force-pushed
the
feat-grubusers
branch
2 times, most recently
from
2b6740f to
c13cf9e
Compare
Add a new [install.ostree] configuration section to allow setting the ostree sysroot.bls-append-except-default option during installation. Closes: bootc-dev#1710 Signed-off-by: Joel Capitao <jcapitao@redhat.com> Co-authored-by: Jean-Baptiste Trystram <jbtrystram@redhat.com> Assisted-by: Claude (Sonnet 4)
joelcapitao
force-pushed
the
feat-grubusers
branch
from
c13cf9e to
b806975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new [install.ostree] configuration section to allow setting the ostree sysroot.bls-append-except-default option during installation.
Closes: #1710
Signed-off-by: Joel Capitao jcapitao@redhat.com
Co-authored-by: Jean-Baptiste Trystram jbtrystram@redhat.com
Assisted-by: Claude (Sonnet 4)