Add /usr overlay info to bootc status#2022
Merged
cgwalters merged 3 commits intobootc-dev:mainfrom Mar 3, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for displaying /usr overlay information in bootc status. The changes are well-implemented, covering both composefs and ostree backends. The new usr_overlay field in the status provides valuable information about the system's state. The code is clean, and tests have been added to verify the new functionality.
I have one suggestion to improve the implementation in crates/lib/src/bootc_composefs/state.rs to avoid redundant syscalls.
Collaborator
|
Looks like this just needs a |
Resolves bootc-dev#474 For bootc-dev#1044 Signed-off-by: Evan Goode <mail@evangoo.de>
Signed-off-by: Evan Goode <mail@evangoo.de>
Signed-off-by: Evan Goode <mail@evangoo.de>
evan-goode
force-pushed
the
evan-goode/bootc-status-usroverlay
branch
from
f7d35ff to
5914112
Compare
Contributor
Author
|
Thanks for the review! Fmtted. |
cgwalters
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks up from #1258 but only adds the
usr_overlayfield to thestatus, not thespecPresumably thespecandeditfunctionality could be added later. It supports querying the /usr overlay status on both composefs and ostree systems.Adding this information to
bootc statuswill be needed for rpm-software-management/dnf5#2358.Resolves #474
For #1044