status: Render cached update info in human-readable output#2047
Draft
cgwalters wants to merge 3 commits intobootc-dev:mainfrom
Draft
status: Render cached update info in human-readable output#2047cgwalters wants to merge 3 commits intobootc-dev:mainfrom
cgwalters wants to merge 3 commits intobootc-dev:mainfrom
Conversation
Run update-generated to sync man pages and tmt plans with current CLI options and test summaries. Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
Deduplicate the timestamp formatting code used in human-readable status output. The format string was inlined with a multi-line comment explaining it; extract it into a named function. Assisted-by: OpenCode (Claude claude-opus-4-6)
After running `bootc upgrade --check`, the registry metadata for a newer image is cached in ostree commit metadata. The `bootc status` command already reads this into the `cachedUpdate` field and exposes it in JSON/YAML output, but the human-readable output never displayed it. This meant users had to parse structured output or re-run `upgrade --check` to see available updates. Render the cached update inline with each deployment entry, showing version, timestamp, and digest when the cached digest differs from the currently deployed image. Relates: https://issues.redhat.com/browse/RHEL-139384 Assisted-by: OpenCode (Claude claude-opus-4-6)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the bootc status command to display cached update information, which is populated by bootc upgrade --check. The implementation is well-structured, introducing a new render_cached_update function and a format_timestamp helper. The changes are thoroughly tested with new unit tests and an integration test, covering various scenarios. The unrelated documentation changes to rename --insecure to --allow-missing-verity also improve clarity. Overall, this is a solid improvement to user experience.
Collaborator
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running
bootc upgrade --check, the registry metadata for anewer image is cached in ostree commit metadata. The
bootc statuscommand already reads this into the
cachedUpdatefield and exposesit in JSON/YAML output, but the human-readable output never displayed
it. This meant users had to parse structured output or re-run
upgrade --checkto see available updates.Render the cached update inline with each deployment entry, showing
version, timestamp, and digest when the cached digest differs from
the currently deployed image.
Relates: https://issues.redhat.com/browse/RHEL-139384