ComposeFS fixes for missing verity#2085
Merged
cgwalters merged 2 commits intobootc-dev:mainfrom Mar 23, 2026
Merged
Conversation
In a few places we were simply searching for the value of composefs cmdline param in the BLS config options, which would not work as expected in cases where missing verity is allowed as the `?` was being counted as part of the digest. Instead, we now use ComposefsCmdline which properly handles the parsing of `?` and the digest Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a solid refactoring that centralizes the logic for handling the composefs kernel command-line parameter. By introducing ComposefsCmdline::build and implementing Display for ComposefsCmdline, you've eliminated manual string formatting and created a single source of truth for constructing this parameter. This not only improves code clarity and maintainability but also fixes a subtle bug where the optional ? prefix for missing verity was being incorrectly handled in some parts of the code. The changes are applied consistently across the codebase. I have one minor suggestion for improvement.
Instead of writing format strings to create a composefs= parameter in the cmdline, add a build method to ComposefsCmdline to build a cmdline from options Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
uki-insecure-fix
branch
from
0f9f655 to
39f3261
Compare
cgwalters
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composefs: Use ComposefsCmdline to handle missing verity
In a few places we were simply searching for the value of composefs
cmdline param in the BLS config options, which would not work as
expected in cases where missing verity is allowed as the
?was beingcounted as part of the digest.
Instead, we now use ComposefsCmdline which properly handles the parsing
of
?and the digestcomposefs: Build composefs cmdline
Instead of writing format strings to create a composefs= parameter in
the cmdline, add a build method to ComposefsCmdline to build a cmdline
from options