Skip to content

provision-derived: Don't hardcode bootupd version#2145

Merged
cgwalters merged 1 commit intobootc-dev:mainfrom
jeckersb:bootupd-copr-version
Apr 16, 2026
Merged

provision-derived: Don't hardcode bootupd version#2145
cgwalters merged 1 commit intobootc-dev:mainfrom
jeckersb:bootupd-copr-version

Conversation

@jeckersb
Copy link
Copy Markdown
Collaborator

This got bumped recently so the old version is no longer available.

Signed-off-by: John Eckersberg jeckersb@redhat.com

@bootc-bot bootc-bot bot requested a review from ckyrouac April 15, 2026 20:20
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the hack/provision-derived.sh script to dynamically resolve the bootupd package version from a COPR repository, replacing a hardcoded version string. This change addresses issues where date-based versioning in the repository caused incorrect package selection. The review feedback recommends refining the dnf repoquery command by specifying the architecture and limiting the output to the latest version to prevent installation failures caused by matching source packages or multiple versions.

Comment thread hack/provision-derived.sh Outdated
@jeckersb jeckersb force-pushed the bootupd-copr-version branch from dbc4d77 to addfa4c Compare April 15, 2026 20:36
Comment thread hack/provision-derived.sh Outdated
Comment on lines +121 to +122
bootupd_nevra=$(dnf --disablerepo=* --enablerepo=copr:copr.fedorainfracloud.org:group_CoreOS:continuous repoquery --latest-limit 1 --arch "$(uname -m)" "bootupd-0.2.*")
dnf -y install ${bootupd_nevra}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dnf -y --disablerepo=* --enablerepo=<copr> distro-sync bootupd would work

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work for me:

[root@8fbeb7e8531f /]# dnf -y --disablerepo=* --enablerepo=copr:copr.fedorainfracloud.org:group_CoreOS:continuous distro-sync bootupd
Updating and loading repositories:
Repositories loaded.
Failed to resolve the transaction:
Packages for argument 'bootupd' available, but not installed.

Probably because of those malformed fc42 packages that I mentioned in the comment in the diff?

@jeckersb
Copy link
Copy Markdown
Collaborator Author

Oh and it looks like the subscription-manager plugin writes to stdout so that's breaking it too.

This got bumped recently so the old version is no longer available.

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@jeckersb jeckersb force-pushed the bootupd-copr-version branch from addfa4c to d6aa779 Compare April 15, 2026 21:19
@jeckersb
Copy link
Copy Markdown
Collaborator Author

Well on a somewhat-positive-since-it's-consistent note, we're seeing the same error on rawhide here that we're seeing over in the fedora dist-git job, so that'll help with tracking that down.

@cgwalters cgwalters merged commit d69621d into bootc-dev:main Apr 16, 2026
59 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants