Handle case where skopeo exits unexpectedly #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confusingly, today running `skopeo some-unknown-command` just outputs usage information to stdout, and exits successfully. I'll probably fix that to exit with an error, but either way we need to handle the case where skopeo exits before we get a reply from the socketpair.
cgwalters
added a commit
to cgwalters/skopeo
that referenced
this pull request
Oct 29, 2021
Surprisingly, the spf13/cobra CLI parsing logic, when presented with an unknown subcommand outputs usage to stdout and *exits successfully*. This is bad for both users and scripts. Cargo cult some code I found in podman to handle this. Motivated by bootc-dev/containers-image-proxy-rs#1
Collaborator
Author
lucab
approved these changes
Oct 29, 2021
cgwalters
added a commit
to cgwalters/skopeo
that referenced
this pull request
Oct 29, 2021
Surprisingly, the spf13/cobra CLI parsing logic, when presented with an unknown subcommand outputs usage to stdout and *exits successfully*. This is bad for both users and scripts. Cargo cult some code I found in podman to handle this. Motivated by bootc-dev/containers-image-proxy-rs#1 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
added a commit
to cgwalters/skopeo
that referenced
this pull request
Oct 29, 2021
Surprisingly, the spf13/cobra CLI parsing logic, when presented with an unknown subcommand outputs usage to stdout and *exits successfully*. This is bad for both users and scripts. Cargo cult some code I found in podman to handle this. Motivated by bootc-dev/containers-image-proxy-rs#1 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
added a commit
to cgwalters/skopeo
that referenced
this pull request
Nov 2, 2021
Surprisingly, the spf13/cobra CLI parsing logic, when presented with an unknown subcommand outputs usage to stdout and *exits successfully*. This is bad for both users and scripts. Cargo cult some code I found in podman to handle this. Motivated by bootc-dev/containers-image-proxy-rs#1 Signed-off-by: Colin Walters <walters@verbum.org>
lsm5
pushed a commit
to containers/skopeo
that referenced
this pull request
Nov 3, 2021
Surprisingly, the spf13/cobra CLI parsing logic, when presented with an unknown subcommand outputs usage to stdout and *exits successfully*. This is bad for both users and scripts. Cargo cult some code I found in podman to handle this. Motivated by bootc-dev/containers-image-proxy-rs#1 Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusingly, today running
skopeo some-unknown-commandjustoutputs usage information to stdout, and exits successfully.
I'll probably fix that to exit with an error, but either
way we need to handle the case where skopeo exits before we get
a reply from the socketpair.