Minimize tokio features
#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Jun 24, 2022
Pairs with ostreedev/ostree-rs-ext#321 and bootc-dev/containers-image-proxy-rs#32 I saw https://www.reddit.com/r/rust/comments/v8e9fa/local_async_executors_and_why_they_should_be_the/ go by and I think it's a good argument why one should use single-threaded tokio by default. Specifically for rpm-ostree, this takes the daemon down from: ``` [root@cosa-devsh ~]# cat /proc/1759/task/*/comm rpm-ostree tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w tokio-runtime-w gmain gdbus pool-/usr/bin/r [root@cosa-devsh ~]# ``` To: ``` [root@cosa-devsh ~]# cat /proc/1437/task/*/comm rpm-ostree tokio-runtime-w gmain gdbus pool-/usr/bin/r [root@cosa-devsh ~]# ``` Which seems way better. A lot less thread stack spam in `t a a bt` in gdb and in coredumps.
I saw this go by https://www.reddit.com/r/rust/comments/v8e9fa/local_async_executors_and_why_they_should_be_the/ and I think it's a good argument why not to use the multithreaded tokio by default. Signed-off-by: Colin Walters <walters@verbum.org>
travier
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this go by
https://www.reddit.com/r/rust/comments/v8e9fa/local_async_executors_and_why_they_should_be_the/
and I think it's a good argument why not to use the multithreaded
tokio by default.