-
Notifications
You must be signed in to change notification settings - Fork 11
Add get_layer_info_json #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d95011b to
c11661c
Compare
src/imageproxy.rs
Outdated
| Ok((fd, finish)) | ||
| } | ||
|
|
||
| ///Exposed LayerInfoForCopy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's provide a bit more documentation, something like:
/// Returns data that can be used to find the "diffid" corresponding to a particular layer.
to start.
|
Also two other things:
|
|
And thanks so much for working on this! |
13ecdcb to
f611ecc
Compare
f611ecc to
9a3e16f
Compare
cgwalters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is looking nice and simple as is. Just one nit on the docs. That said...I'm thinking we may need to add a bit more complexity here to handle ostreedev/ostree-rs-ext#396 (comment)
We can have a realtime chat about this but basically...if we choose to go with the "dynamic detection" route, we'd need to dynamically check the protocol version the remote gives us.
See e.g. the code around let protover = semver::Version::parse(protover.as_str())?;
6e3cf79 to
8f9e286
Compare
Cargo.toml
Outdated
| [features] | ||
| # See https://github.com/containers/skopeo/blob/03da797e42374892bca8759668adb0b06d087876/cmd/skopeo/proxy.go#L95 | ||
| proxy_v0_2_4 = [] | ||
| proxy_v0_2_5 = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this?
This API exposes the "GetLayerInfosForCopy" API in containers/image, which can be used to create a mapping between blob and diff IDs, allowing pulling via diffID. Signed-off-by: RishabhSaini <rsaini@redhat.com>
8f9e286 to
b801e4a
Compare
cgwalters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This API exposes the "GetLayerInfosForCopy" API in containers/image,
which can be used to create a mapping between blob and diff IDs,
allowing pulling via diffID.
Signed-off-by: RishabhSaini rsaini@redhat.com