devcontainer: Switch to --privileged for Codespaces compatibility#136
devcontainer: Switch to --privileged for Codespaces compatibility#136cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the devcontainer setup by consolidating complex security arguments into a single --privileged flag, significantly improving compatibility across various development platforms. It also introduces a mechanism for devaipod to enforce a more granular and secure environment when active, ensuring a balance between ease of use and security. Additionally, it enhances development workflow by enabling automated CI testing for devcontainer configuration changes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request switches the devcontainer configuration to use privileged mode for better compatibility with Codespaces. While this may be necessary, it introduces a significant security risk by granting the container full access to the host. My review includes a critical comment highlighting this security concern. Additionally, I've pointed out a redundant configuration entry that can be removed.
2179c54 to
8aa5978
Compare
Replace fine-grained capability/security-opt arguments (--cap-add=all, label=disable, unmask=/proc/*, etc.) with --privileged for broad compatibility across Codespaces, Docker, and the stock devcontainer CLI. Add the devaipod nestedContainers customization so that devaipod can apply a tighter security profile (SYS_ADMIN, NET_ADMIN, unmask=/proc/*, label=disable, seccomp=unconfined) instead of full --privileged when running under its control. Also trigger the test-devcontainer CI workflow on .devcontainer/ changes. Closes: bootc-dev#135 Assisted-by: OpenCode (Claude claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
8aa5978 to
f4bab9d
Compare
Replace fine-grained capability/security-opt arguments (--cap-add=all, label=disable, unmask=/proc/*, etc.) with --privileged for broad compatibility across Codespaces, Docker, and the stock devcontainer CLI.
Add the devaipod nestedContainers customization so that devaipod can apply a tighter security profile (SYS_ADMIN, NET_ADMIN, unmask=/proc/*, label=disable, seccomp=unconfined) instead of full --privileged when running under its control.
Also trigger the test-devcontainer CI workflow on .devcontainer/ changes.
Closes: #135
Assisted-by: OpenCode (Claude claude-opus-4-6)