Conversation
There's a fundamental conflict between: - Copying GHA workflows from here into repos - Updating GHA via renovate We previously had to hackily exclude the GHA in this repo from the renovate config. It's just cleaner to do GHA reuse the more "native" Github way by publishing composite actions, which we're doing in bootc-dev/actions now (for scorecard for example). The rebase action isn't but it was broken anyways because of permissions, let's drop it and we can reintroduce it at some point if needed, but honestly since many rebases need code changes anyways it's cleaner to just defer that to humans. Signed-off-by: Colin Walters <walters@verbum.org>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the management of GitHub Actions workflows by removing them from the 'common/' directory. This change addresses a fundamental conflict with Renovate's update mechanism and shifts towards a more robust and native GitHub approach for workflow reuse through composite actions. Additionally, a previously broken automatic rebase workflow has been removed, favoring manual intervention for rebase operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the openssf-scorecard-gate.yml and rebase.yml GitHub Actions workflows from the common/ directory. This change addresses a conflict between the file-copying synchronization method and automated dependency updates via Renovate. The new approach favors reusable composite actions, which is a more standard and maintainable way to share GitHub Actions logic. The rebase workflow is also being removed because it was non-functional and manual intervention is often required for rebases anyway. The file deletions are a logical step in this strategic shift.
2 participants
There's a fundamental conflict between:
We previously had to hackily exclude the GHA in this repo from the renovate config.
It's just cleaner to do GHA reuse the more "native" Github way by publishing composite actions, which we're doing in bootc-dev/actions now (for scorecard for example).
The rebase action isn't but it was broken anyways because of permissions, let's drop it and we can reintroduce it at some point if needed, but honestly since many rebases need code changes anyways it's cleaner to just defer that to humans.