devenv: Deduplicate kani setup and devcontainer configs#145
devenv: Deduplicate kani setup and devcontainer configs#145cgwalters merged 1 commit intobootc-dev:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the development environment setup by addressing two key areas: streamlining Kani's dependency installation and improving devcontainer configuration management. By moving Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively deduplicates the gcc installation logic by centralizing it in install-kani.sh and introduces just recipes for managing devcontainer configurations, which improves maintainability. The changes are well-structured. I have a couple of suggestions to enhance the robustness and scripting style of the new additions.
| done | ||
|
|
||
| # Validate devcontainer.json syntax and that per-OS configs are in sync | ||
| devcontainer-validate: |
There was a problem hiding this comment.
But nothing is invoking this in CI?
There was a problem hiding this comment.
You marked this as resolved but it seems unchanged? What I meant was: if someone modifies one of the container files directly, it won't fail CI but it should
There was a problem hiding this comment.
The just devcontainer-validate is already called in the build-devcontainer.yml workflow. I added 'common/.devcontainer/**' in line 10 to trigger validation when devcontainer configs change.
There was a problem hiding this comment.
Got it sorry! I was confused when reading the diff, I missed that the validate line didn't change and that meant it was already called.
Move gcc installation into install-kani.sh so the distro-specific package manager command isn't duplicated across all three Containerfiles. The script auto-detects dnf vs apt-get. Add devcontainer-generate and devcontainer-validate recipes to generate per-OS devcontainer.json files from the default template and validate they stay in sync. Assisted-by: Claude Code (Opus 4.6) Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
2 participants
Move gcc installation into install-kani.sh so the distro-specific package manager command isn't duplicated across all three Containerfiles. The script auto-detects dnf vs apt-get.
Add devcontainer-generate and devcontainer-validate recipes to generate per-OS devcontainer.json files from the default template and validate they stay in sync.
Assisted-by: Claude Code (Opus 4.6)