Skip to content

bootc-ubuntu-setup: Bump bcvk to 0.8.0 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
Merged

bootc-ubuntu-setup: Bump bcvk to 0.8.0 #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/.github/actions/bootc-ubuntu-setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ runs:
shell: bash
run: |
set -xeuo pipefail
export BCVK_VERSION=0.7.0
export BCVK_VERSION=0.8.0
Copy link

@gemini-code-assist gemini-code-assist bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and flexibility, consider making this version number an input to the composite action rather than hardcoding it. This would allow consumers of this action to override the version if needed, and it centralizes the configuration, making future updates easier.

You could add an input like this to your action.yml:

inputs:
  # ... other inputs
  bcvk-version:
    description: 'The version of bcvk to install.'
    required: false
    default: '0.8.0'

Then, you could reference it in your run step using ${{ inputs.bcvk-version }}, which would also allow you to remove the export line.

/bin/time -f '%E %C' sudo apt install -y libkrb5-dev pkg-config libvirt-dev genisoimage qemu-utils qemu-kvm virtiofsd libvirt-daemon-system
# Something in the stack is overriding this, but we want session right now for bcvk
echo LIBVIRT_DEFAULT_URI=qemu:///session >> $GITHUB_ENV
Expand Down