-
Notifications
You must be signed in to change notification settings - Fork 3
common: Add OpenSSF Scorecard gating workflow #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a stub workflow that calls bootc-dev/actions/openssf-scorecard to gate PRs on scorecard regressions. Also adds scorecard to devenv images for local development, and a renovate custom manager for VERSION= patterns in YAML files. Requires: bootc-dev/actions#2 Assisted-by: OpenCode (Claude Sonnet 4) Signed-off-by: Colin Walters <walters@verbum.org>
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's security posture by implementing a new GitHub Actions workflow that actively gates pull requests based on OpenSSF Scorecard regressions. This change moves from a reactive analysis approach to a proactive prevention strategy. Additionally, it integrates the OpenSSF Scorecard tool directly into the development container images, allowing developers to utilize it locally. The PR also improves dependency management by extending Renovate's capabilities to recognize and update version declarations in YAML files. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an OpenSSF Scorecard gating workflow and integrates the scorecard tool into development environment containers, aiming to enhance security standards. However, a security audit identified several vulnerabilities. A medium-severity issue exists in the new GitHub workflow, which uses a mutable branch reference for an action, posing a risk of executing untrusted code. Furthermore, two high-severity command injection vulnerabilities were found in the Containerfile for both c10s and debian, caused by unquoted build arguments that could allow arbitrary code execution. To improve robustness, it's also recommended to pin GitHub Actions to specific versions and add checksum verification for downloaded binaries.
Adds a stub workflow that calls bootc-dev/actions/openssf-scorecard to gate PRs on scorecard regressions.
Also adds scorecard to devenv images for local development, and a renovate custom manager for VERSION= patterns in YAML files.
Requires: bootc-dev/actions#2
Assisted-by: OpenCode (Claude Sonnet 4)