disk: Simplify logging with attach API, use tty #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `Attach` API is *way* simpler than us forwarding output manually. Set up a terminal by default, and together this fixes things like having bootc display an interactive spinner. Signed-off-by: Colin Walters <walters@verbum.org>
ckyrouac
approved these changes
May 20, 2024
Collaborator
|
agh, I accidentally ran the e2e tests against main thinking I was running them against this branch. This broke the e2e tests, and the |
Collaborator
Author
|
Hmm. Sorry for not running those tests! Let's go ahead and revert. |
Collaborator
Author
#41 fixes this for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
AttachAPI is way simpler than us forwarding output manually.Set up a terminal by default, and together this fixes things like having bootc display an interactive spinner.