disk: Switch to just invoking podman run
#61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
fix-attach
branch
2 times, most recently
from
0f85e32 to
e58142d
Compare
germag
reviewed
Jul 9, 2024
cgwalters
added a commit
to cgwalters/podman
that referenced
this pull request
Jul 9, 2024
See: - bootc-dev/podman-bootc#59 (comment) - bootc-dev/podman-bootc#61 Sorry for not trying to fix this, but I am not aware of a remotely straightforward way to do so. Signed-off-by: Colin Walters <walters@verbum.org>
Merged
This works around a goroutine leak in the `Attach` API. Honestly I think it's also just simpler for our use case here; we don't need the container ID for example because it's ephemeral, etc. Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a goroutine leak in the
AttachAPI. Honestly I think it's also just simpler for our use case here; we don't need the container ID for example because it's ephemeral, etc.xref: containers/podman#23233