better display of errors#182
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves CLI renderer output to show the underlying command that failed when a lesson submission fails, making error displays more actionable for users (per issue #8112).
Changes:
- When result is
failure, prints aFailed Command:line derived from the step text atFailedStepIndex. - Adds bounds-checking around indexing into
m.stepsfor the failed-command display.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Looks good to me! Maybe ask Lane/Hunter for product approval? They may have some opinions about how it should look. |
skovranek
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/bootdotdev/go-api-gate/issues/8112
The first run is using this change. Note the
Failed Command: Running: go test -v. The second run is what we currently have.