Skip to content

add bolt_store#13

Merged
bootjp merged 6 commits intomainfrom
devlop
Dec 5, 2023
Merged

add bolt_store#13
bootjp merged 6 commits intomainfrom
devlop

Conversation

@bootjp
Copy link
Copy Markdown
Owner

@bootjp bootjp commented Dec 5, 2023

No description provided.

Comment thread kv/bolt_store.go Outdated

import (
"context"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default (gci)

Comment thread kv/bolt_store.go Outdated
"os"
"sync"

"go.etcd.io/bbolt"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default (gci)

Comment thread kv/bolt_store.go

"go.etcd.io/bbolt"

"github.com/cockroachdb/errors"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gci-ed with --skip-generated -s standard -s default (gci)

Comment thread kv/bolt_store.go Outdated
}

func NewBoltStore() (Store, error) {
db, err := bbolt.Open("my.db", 0666, nil)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
mnd: Magic number: 0666, in detected (gomnd)

Comment thread kv/bolt_store.go Outdated
if err != nil {
return errors.WithStack(err)
}
return b.Put(key, value)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
error returned from external package is unwrapped: sig: func (*go.etcd.io/bbolt.Bucket).Put(key []byte, value []byte) error (wrapcheck)

Comment thread kv/bolt_store.go Outdated
}

func NewBoltStore(path string) (Store, error) {
db, err := bbolt.Open(path, 0666, nil)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
mnd: Magic number: 0666, in detected (gomnd)

@bootjp bootjp merged commit 56b9fe6 into main Dec 5, 2023
@bootjp bootjp deleted the devlop branch December 5, 2023 14:43
@claude claude Bot mentioned this pull request May 2, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant