store: replace binary.Write with binary.BigEndian.PutUint64 in encodeSortableInt64#343
Merged
bootjp merged 3 commits intofeature/dynamodbfrom Mar 13, 2026
Merged
store: replace binary.Write with binary.BigEndian.PutUint64 in encodeSortableInt64#343bootjp merged 3 commits intofeature/dynamodbfrom
bootjp merged 3 commits intofeature/dynamodbfrom
Conversation
Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
…SortableInt64 Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on storing DynamoDB schemas as protobuf
store: replace binary.Write with binary.BigEndian.PutUint64 in encodeSortableInt64
Mar 13, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| buf := bytes.NewBuffer(dst[:0]) | ||
| _ = binary.Write(buf, binary.BigEndian, seq^math.MinInt64) | ||
| binary.BigEndian.PutUint64(dst, uint64(seq^math.MinInt64)) |
Contributor
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
G115: integer overflow conversion int64 -> uint64 (gosec)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encodeSortableInt64was usingbytes.NewBuffer+binary.Write, introducing a heap allocation and reflection overhead on every call in a hot-path helper, while silently discarding the write error.Changes
store/list_helpers.go: Replace allocation-heavy pattern with a direct, zero-allocationbinary.BigEndian.PutUint64write:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.