Skip to content

Fix redis-proxy deployment docs: workflow trigger accuracy and docker run port mapping#369

Merged
bootjp merged 3 commits intofeature/redis-proxyfrom
copilot/sub-pr-367-again
Mar 20, 2026
Merged

Fix redis-proxy deployment docs: workflow trigger accuracy and docker run port mapping#369
bootjp merged 3 commits intofeature/redis-proxyfrom
copilot/sub-pr-367-again

Conversation

Copy link
Contributor

Copilot AI commented Mar 20, 2026

Two inaccuracies in docs/redis-proxy-deployment.md identified during review.

Changes

  • Workflow trigger description — "on every push to main" was incorrect; the workflow only fires when specific paths change (cmd/redis-proxy/, proxy/, Dockerfile.redis-proxy, etc.). Updated to reflect the path-filtered behavior.
  • Minimal docker run example — missing -p 6379:6379 meant the proxy was unreachable from the host in a typical local run. Added the port mapping.
docker run --rm \
  -p 6379:6379 \
  ghcr.io/bootjp/elastickv/redis-proxy:latest \
  -listen :6379 \
  -primary redis.internal:6379 \
  -mode redis-only

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
Copilot AI changed the title [WIP] Add redis-proxy Dockerfile, GHCR publishing workflow, and deployment guide Fix redis-proxy deployment docs: workflow trigger accuracy and docker run port mapping Mar 20, 2026
Copilot AI requested a review from bootjp March 20, 2026 09:36
@bootjp bootjp marked this pull request as ready for review March 20, 2026 09:50
@bootjp bootjp merged commit 1caf3b3 into feature/redis-proxy Mar 20, 2026
3 checks passed
@bootjp bootjp deleted the copilot/sub-pr-367-again branch March 20, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants