proxy: fix EVALSHA_RO fallback, guard script cache on primary error, bounded eviction#373
Merged
bootjp merged 2 commits intocodex/primary-blocking-bzpopminfrom Mar 20, 2026
Merged
Conversation
…add bounded eviction Co-authored-by: bootjp <1306365+bootjp@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add proxy-side support for Redis blocking commands
proxy: fix EVALSHA_RO fallback, guard script cache on primary error, bounded eviction
Mar 20, 2026
bootjp
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs in the proxy-side script cache introduced in the previous commit.
EVALSHA_ROfell back toEVALinstead ofEVAL_RORead-only semantics were silently dropped on secondary replay.
evalFallbackArgsnow mapsEVALSHA_RO → EVAL_ROandEVALSHA → EVAL.Script cache mutated on primary failure
rememberScript(includingclearScriptsforSCRIPT FLUSH) was called before checking the primary's error. A failedSCRIPT FLUSHwould clear the proxy cache while the primary still held its scripts, breaking subsequentEVALSHA → EVALfallbacks. MovedrememberScriptto after the error guard.Unbounded script cache
The
scripts map[string]stringhad no size limit. AddedmaxScriptCacheSize = 512with FIFO eviction tracked via an insertion-orderscriptOrder []stringslice—no new dependencies required.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.