-
Notifications
You must be signed in to change notification settings - Fork 2
add s3 adapter #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add s3 adapter #396
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
8fc2dd3
adapter: harden s3 routing and consistency
bootjp bf5f059
adapter: address s3 review feedback
bootjp 1e9f817
Initial plan
Copilot 8d240fb
address review comments: HLC monotonicity, SigV4 sig comparison, coor…
Copilot 269c231
Merge pull request #399 from bootjp/copilot/sub-pr-396
bootjp 8a83366
Initial plan
Copilot 60ed277
fix: HLC monotonicity, nil guards in Run(), and coordinator/config pa…
Copilot 9c629f7
Merge pull request #402 from bootjp/copilot/sub-pr-396
bootjp 5259dfc
Initial plan
Copilot 41a7f2c
fix: s3 error leakage, HLC observe, and PUT body size limit
Copilot 8e41c18
Merge pull request #404 from bootjp/copilot/sub-pr-396
bootjp e8085ea
Initial plan
Copilot 57983e3
Merge branch 'main' into feature/s3-impl
bootjp 2edcd2a
fix: bound cleanup goroutines, fix retry off-by-one, log dispatch errors
Copilot 1fe3490
Initial plan
Copilot e951182
fix: add missing setupFSMStore function lost in merge
Copilot 24df609
fix: reduce run() cyclomatic complexity to satisfy cyclop linter
Copilot 7ad71a7
Merge pull request #408 from bootjp/copilot/sub-pr-396-again
bootjp 418fcd8
Merge branch 'feature/s3-impl' into copilot/sub-pr-396
bootjp 52cf0ec
fix: reduce cleanupManifestBlobs cyclomatic complexity for cyclop linter
Copilot dd673c0
Merge pull request #407 from bootjp/copilot/sub-pr-396
bootjp 05a1fd6
Initial plan
Copilot 0d17d92
Fix ListObjectsV2 pagination: parse token first, load meta at consist…
Copilot c98b088
Merge pull request #409 from bootjp/copilot/sub-pr-396
bootjp 128503f
Update cmd/server/demo.go
bootjp 2d25ed4
Initial plan
Copilot 65d9eaf
adapter/s3: use base64.RawURLEncoding for continuation tokens
Copilot b3c2459
cmd/server: fix range over iter.Seq compile error in demo.go
Copilot b41181d
Merge pull request #410 from bootjp/copilot/sub-pr-396
bootjp 7aa00f7
Initial plan
Copilot 61fa09e
kv: fix reverseScanRoutesAt to merge+sort descending when clampToRout…
Copilot d6fd20f
kv: add tests for ReverseScanAt cross-shard ordering and mergeAndTrim…
Copilot bd857e7
Merge pull request #411 from bootjp/copilot/sub-pr-396
bootjp 90e6e70
Initial plan
Copilot 7682358
Fix s3/shard_store issues: always sort in mergeAndTrimReverseScanResu…
Copilot ca7a3b6
Merge pull request #412 from bootjp/copilot/sub-pr-396
bootjp 28d6633
Initial plan
Copilot c61c8d1
kv: zero CommitTS when StartTS is auto-assigned in coordinators
Copilot 9a09659
Merge pull request #413 from bootjp/copilot/sub-pr-396
bootjp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localAdapterCoordinator.commitTSForRequest accepts a caller-provided CommitTS but does not Observe() it on the HLC. If a test provides a CommitTS ahead of the coordinator clock, subsequent Next() calls can go backwards relative to that CommitTS, which can make timestamp-dependent behavior flaky or diverge from production coordinator behavior. Consider observing non-zero CommitTS (and/or StartTS) to keep the test clock monotonic.