docs(design): rename Composed-1 docs *_proposed_* → *_partial_* (M5a shipped)#927
docs(design): rename Composed-1 docs *_proposed_* → *_partial_* (M5a shipped)#927bootjp wants to merge 3 commits into
Conversation
… shipped)
Per CLAUDE.md design-doc lifecycle (rename after the first
milestone ships): both Composed-1 design docs move from
*_proposed_* to *_partial_* now that M5a has fully landed on main.
Parent doc:
2026_05_29_proposed_composed1_cross_group_commit_guard.md
-> 2026_05_29_partial_composed1_cross_group_commit_guard.md
Status header updated to record:
- M1-M4 shipped via PR #900
- M5a shipped via PRs #911 / #916 / #924 / #925
- M5b (route-shuffle nemesis) still open
M5 doc:
2026_06_02_proposed_composed1_m5_jepsen_route_shuffle.md
-> 2026_06_02_partial_composed1_m5_jepsen_route_shuffle.md
Status header enumerates the M5a delivery PRs, the cross-PR
PR #926 fix discovered during E2E, and a separate
ResourceNotFoundException follow-up issue still under
investigation.
Parent-doc cross-reference link updated to point at the renamed
partner so internal navigation stays correct after the rename.
Doc-only change. All other content preserved verbatim per the
lifecycle convention (only the status block evolves; the design
body is the as-shipped record from each milestone).
|
Warning Review limit reached
More reviews will be available in 52 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughThis PR updates design document references throughout the codebase from "proposed" to "partial" status, reflecting maturity progression of two independent feature initiatives: M5 Jepsen route-shuffle testing and Composed-1 cross-group commit guard. The design documents themselves are updated with status metadata and completion checklists. ChangesM5 Jepsen Route-Shuffle Design and References
Cross-Group Commit Guard Design and References
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates two design documents to transition their status from 'Proposed' to 'Partial', documenting the milestones shipped and updating the file references accordingly. The feedback suggests a Markdown formatting improvement to avoid starting a line with a '#' character (e.g., '#911'), which could be misparsed as a header by some Markdown parsers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| Status: Partial — M1–M4 shipped via PR #900; M5a shipped via PRs | ||
| #911 / #916 / #924 / #925; M5b (route-shuffle nemesis) still | ||
| open. See companion doc | ||
| `2026_06_02_partial_composed1_m5_jepsen_route_shuffle.md` for the | ||
| detailed M5 design and per-milestone state. |
There was a problem hiding this comment.
Markdownにおいて、行頭が # で始まる文字列（例: #911）は、一部のパーサーによって見出し（Header）として誤って解釈されたり、表示が崩れたりする可能性があります。行頭に # が来ないように改行位置を調整するか、段落を1行にまとめることを推奨します。
| Status: Partial — M1–M4 shipped via PR #900; M5a shipped via PRs | |
| #911 / #916 / #924 / #925; M5b (route-shuffle nemesis) still | |
| open. See companion doc | |
| `2026_06_02_partial_composed1_m5_jepsen_route_shuffle.md` for the | |
| detailed M5 design and per-milestone state. | |
| Status: Partial — M1–M4 shipped via PR #900; M5a shipped via PRs #911 / #916 / #924 / #925; M5b (route-shuffle nemesis) still open. See companion doc 2026_06_02_partial_composed1_m5_jepsen_route_shuffle.md for the detailed M5 design and per-milestone state. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d667b526ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Date: 2026-06-02 (renamed *_proposed_* → *_partial_* on 2026-06-04) | ||
| Parent design: | ||
| [`2026_05_29_proposed_composed1_cross_group_commit_guard.md`](2026_05_29_proposed_composed1_cross_group_commit_guard.md) | ||
| [`2026_05_29_partial_composed1_cross_group_commit_guard.md`](2026_05_29_partial_composed1_cross_group_commit_guard.md) |
There was a problem hiding this comment.
Because this commit removes the old *_proposed_* filenames, the remaining repo references now point at missing files; I checked with rg "2026_05_29_proposed_composed1|2026_06_02_proposed_composed1" and found stale paths in implementation comments and scripts such as cmd/elastickv-route-key/main.go, kv/fsm.go, jepsen/src/elastickv/dynamodb_multi_table_workload.clj, and scripts/run-jepsen-m5-local.sh. Anyone following those design-doc pointers from the code will land on nonexistent files unless the references are updated along with this link.
Useful? React with 👍 / 👎.
…ten Status (codex P2 + gemini medium on PR #927) codex P2 — 16 ファイルに古い *_proposed_* パス参照が残存。 全部 *_partial_* に更新 (cmd/, distribution/, jepsen/, kv/, main.go, proto/, scripts/). generated proto/internal.pb.go は source proto/internal.proto の同期更新と一致するため sed で同時置換 (regen 不要)。 gemini medium — markdown 行頭の '#911' が見出しとして誤解釈 される懸念。 親 doc の Status section を 1 行にまとめて回避。 go build ./... -> exit 0
|
Pushed as b527dd5 — codex P2 + gemini medium on d667b52 addressed. codex P2 — リネーム後の stale references 16 ファイル一括修正:
gemini medium — markdown 行頭
@claude review |
TLA+ spec divergence review (auto-triggered)This PR touches files that the TLA+ safety spec has an anchor on (per Anchored files changed in this PR head (b527dd5):
What to check, by subsystem:
If the change is correct but requires a spec update, edit @claude review please verify TLA+ spec divergence per the checklist above. @codex review please verify TLA+ spec divergence per the checklist above. |
|
To use Codex here, create a Codex account and connect to github. |
|
Claude finished @bootjp's task in 1m 49s —— View job Review — docs/composed1-partial-rename (b527dd5)
SummaryThe rename + stale-reference sweep is solid. One file was missed in the Finding: one remaining stale reference —
|
|
Claude finished @bootjp's task in 1m 20s —— View job Review — docs/composed1-partial-rename (39769a9)
LGTM — fix is correct, repo is clean
-\* 2026_05_29_proposed_composed1_cross_group_commit_guard.md
+\* 2026_05_29_partial_composed1_cross_group_commit_guard.mdCorrect surgical fix. The commit message accurately documents the root cause (the earlier Final scan result: All 18 changed files across the three commits in this PR are consistent. The other This PR is ready to merge. |
TLA+ spec divergence review (auto-triggered)This PR touches files that the TLA+ safety spec has an anchor on (per Anchored files changed in this PR head (39769a9):
What to check, by subsystem:
If the change is correct but requires a spec update, edit @claude review please verify TLA+ spec divergence per the checklist above. @codex review please verify TLA+ spec divergence per the checklist above. |
|
To use Codex here, create a Codex account and connect to github. |
1 participant
CLAUDE.md の design-doc lifecycle 規約に従い、Composed-1 関連の 2 つの design doc を
*_proposed_*→*_partial_*にリネーム。M5a が main にランドしたタイミング。Renames
Status header の更新
親 doc (cross-group commit guard):
M5 doc:
--hostfix) を E2E 中に発見ResourceNotFoundExceptionfollow-up issue を tracked separately として記載親子相互参照リンクの更新
M5 doc の "Parent design" リンクをリネーム後のファイル名に変更。
Body content
CLAUDE.md の lifecycle 規約通り、design 本体は as-shipped record として温存。Status block のみ進化させる。
Test plan
git mvで履歴を保持Summary by CodeRabbit