Skip to content

Remove rotation and edge detection. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izaakschroeder merged 1 commit into from
May 24, 2017
Merged

Remove rotation and edge detection. #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 1 addition & 47 deletions src/flowtip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export default class Flowtip extends Component {
}

availableAndFitsIn([region, ...regions], regionParameter) {
if (!regions || regions.length <= 0) {
if (!region) {
return this.props.region;
}

Expand Down Expand Up @@ -352,52 +352,6 @@ export default class Flowtip extends Component {
], regionParameter);
}

// Edge detection - squeeze
if (
(region === 'top' || region === 'bottom') &&
!regionParameter.top.fits && !regionParameter.bottom.fits
) {
region = this.availableAndFitsIn(['left', 'right'], regionParameter);
} else if (
(region === 'left' || region === 'right') &&
!regionParameter.left.fits && !regionParameter.right.fits
) {
region = this.availableAndFitsIn(['top', 'bottom'], regionParameter);
}

// Edge detection - rotate
let rotation;
if (region === 'top' || region === 'bottom') {
if (
(parent.left + parent.width) -
(target.left + (target.width / 2)) - this.props.edgeOffset <
this.props.rotationOffset
) {
rotation = region === 'top' ? ['left', 'bottom'] : ['left', 'top'];
} else if (
target.left + (target.width / 2) - this.props.edgeOffset <
parent.left + this.props.rotationOffset
) {
rotation = region === 'top' ? ['right', 'bottom'] : ['right', 'top'];
}
} else if (region === 'left' || region === 'right') {
if (
(parent.top + parent.height) - (target.top + (target.height / 2)) -
this.props.edgeOffset < this.props.rotationOffset
) {
rotation = region === 'left' ? ['top', 'right'] : ['top', 'left'];
} else if (
target.top + (target.height / 2) - this.props.edgeOffset <
parent.top + this.props.rotationOffset
) {
rotation = region === 'left' ? ['bottom', 'right'] : ['bottom', 'left'];
}
}

if (rotation) {
region = this.availableAndFitsIn(rotation, regionParameter);
}

return region;
}

Expand Down