Skip to content

Conversation

@hab
Copy link
Contributor

@hab hab commented Nov 21, 2014

I needed to monkey-patch the FormBuilder and found that the message list is built the same way in two places. This patch simply reuses the existing method to get the list of error messages.

Also, I found an issue with specifying non-default label column span on the form tag, e.g.

= bootstrap_form_for item, layout: :horizontal, label_col: 'col-sm-3', control_col: 'col-sm-9' do |f|
   = f.form_group do
      p Hello there

The paragraph would only be offset by two columns instead of three as specified at the form level.

@carloslopes
Copy link
Member

Thanks! ❤️

carloslopes added a commit that referenced this pull request Dec 24, 2014
generate_help reuses the existing get_error_messages method

Closes #175
@carloslopes carloslopes merged commit 5e498df into bootstrap-ruby:master Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants