Add classes to the div.form-check that wraps check boxes and radio buttons.
#479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcreid
force-pushed
the
476-wrapper-class
branch
from
608e5a6 to
c34e4d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap 4 wraps check boxes and radio buttons in a
div.form-check. Similar to thediv.form-grouparound other controls, this PR allows the programmer to add classes to the "wrapper"div.form-check, like we currently allow for thediv.form-group.This PR extends the
wrapper_classoption tocheck_boxandradio_buttonhelpers, and applies the classes to thediv.form-checkaround the label and control for the check box or radio button.This PR also includes some refactoring in
check_boxandradio_button. The first commit shows the refactoring oncheck_box. The second adds the wrapper_class functionality. The third commit does the refactoring and adds the functionality onradio_button. (Sorry. I forgot the commit for the refactoring.) Finally, there is a commit to eliminate a test foroptions[:custom]in bothcheck_boxandradio_button.Fixes #476.