Study card: scrollable content + slide-up rating buttons#11
Merged
Conversation
added 7 commits
June 4, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two study-screen polish improvements on the flip card:
FlipCard.kt→CardFace): long question/answer text now scrolls instead of clipping, while short content stays vertically centered —BoxWithConstraints { Column(verticalScroll().heightIn(min = maxHeight), verticalArrangement = Center) }, the Compose analog of iOS'sScrollView { }.frame(minHeight:). Horizontal padding sits outside the scroll; tap-to-flip and drag-to-scroll coexist; back-face counter-rotation preserved.StudyScreen.kt→StudyCard): on reveal, the four rating buttons slide up from the bottom + fade in while the "Tap to flip" hint cross-fades. Implemented as a fixed-heightBoxwith two z-stackedColumnlayers (each hosting anAnimatedVisibility) so the buttons slide over the fading hint rather than being clipped below it.Also fixes a pre-existing broken instrumented test (
StudyContentTestasserted a "Show answer" button that the flip card removed in #8) to use tap-to-flip.Notes
AnimatedVisibility(Boolean)isColumnScope/RowScope-only (no top-level overload), so the overlap is achieved via twoColumn(fillMaxSize)layers in aBox.Test Plan
:app:testDebugUnitTestpasses (no regressions).:app:compileDebugKotlin+:app:compileDebugAndroidTestKotlinbuild clean (instrumented tests compile-verified; emulator unavailable to run them).🤖 Generated with Claude Code