Fixes the man pages creation#4779
Conversation
The issue borgbackup#4471 solution created many commands for borgfs which shouldn't exist in addition to creating issue borgbackup#4752. Fixes borgbackup#4752 .
Gu1nness
force-pushed
the
issue-4752-build-man-is-broken
branch
from
5df4f43 to
dd92695
Compare
Codecov Report
@@ Coverage Diff @@
## master #4779 +/- ##
==========================================
+ Coverage 83.84% 83.97% +0.12%
==========================================
Files 37 37
Lines 9762 9763 +1
Branches 1622 1621 -1
==========================================
+ Hits 8185 8198 +13
+ Misses 1103 1095 -8
+ Partials 474 470 -4
Continue to review full report at Codecov.
|
ThomasWaldmann
left a comment
ThomasWaldmann
left a comment
There was a problem hiding this comment.
Is a bit hard to review due to the code moved around, but I assume that most stuff is just moved and has no changes?
Other than that, it looks good.
Did you test the manpage creation via setup.py?
Did you also check borg --help and borgfs --help?
src/borg/archiver.py
Outdated
| group.add_argument('--last', metavar='N', dest='last', default=0, type=positive_int_validator, | ||
| help='consider last N archives after other filters were applied') | ||
|
|
||
| def define_borg_mount(subparser): |
There was a problem hiding this comment.
guess this should be parser.
that the parser can be in fact a subparser sometimes is a detail not needed here (and also is not true for borgfs).
src/borg/archiver.py
Outdated
| subparser = parser | ||
| define_borg_mount(subparser) |
There was a problem hiding this comment.
replace these 2 lines by:
define_borg_mount(parser)
The introduction of the subparser name is a relict from the old code structure - but as you have it as a function paramenter now, it is not needed any more.
|
Oh dear, guess that is my fault, the fix for issue #4471 was mine... |
|
Indeed most of the patch is moving the code around. |
|
Thanks! Is this change only needed for master or also for 1.1-maint? |
|
Also, see #4789, there might be another issue. |
|
It does not seem to be necessary for 1.1-maint the man pages build correctly. borg-init(1), borg-create(1), borg-mount(1), borg-extract(1), borg-list(1), borg-info(1), borg-delete(1), borg-prune(1), borg-recreate(1 |
|
1.1-maint: ok, good. what i meant with #4789 issue is that the borg.1 manpage is not updated. |
|
Oh yeah indeed. |
4 participants
The issue #4471 solution
created many commands for borgfs which shouldn't exist in addition to
creating issue #4752.
Fixes #4752 .