repo commands renamed r* -> repo-*#8358
Conversation
also: - adapt tests - adapt BuildMan manpage generation - adapt help strings / doc strings - docs
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #8358 +/- ##
=======================================
Coverage 81.73% 81.74%
=======================================
Files 70 70
Lines 12648 12648
Branches 2287 2287
=======================================
+ Hits 10338 10339 +1
Misses 1665 1665
+ Partials 645 644 -1 ☔ View full report in Codecov by Sentry. |
|
While working on this, I thought we maybe should rename some other commands also. disambiguation / split vs. describing scopeThe initial reason to have But the command name could also describe the scope the command works on: full repo vs. archive(s). compactThus checkThis is currently a mixed-scope command, there is the --repository-only part doing the full repo low-level check and the --archives-only higher level check. By default it runs both of them. pruneDifficult. Potentially works on the full repo, but rules rather apply on the archive level. |
|
I'd not give prune/check prefixes for now The repo only/Archive only versions could be turned into separate prefixed commands Prune is kind of a repo wide operation that's specifically targeting the full list of archives |
133ad5d to
cfd35b4
Compare
|
Still need feedback on That works on full repo scope, but it's doing the garbage collection by looking at all archives. |
|
Will merge this soon to avoid conflicts. Can work on compact in another PR... |
When in doubt and since this operates on both, I'd keep the old version of |
|
I second keeping |
|
@witten there is nothing to compact "in archives". It just needs to analyze the archives to know what chunks are in use, so it can delete those which aren't used. It also computes some stats as a side effect (-v). |
Fixes #8292.