Chunker: split file reading and chunking#8881
Closed
ThomasWaldmann wants to merge 3 commits intoborgbackup:masterfrom
Closed
Chunker: split file reading and chunking#8881ThomasWaldmann wants to merge 3 commits intoborgbackup:masterfrom
ThomasWaldmann wants to merge 3 commits intoborgbackup:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8881 +/- ##
==========================================
+ Coverage 82.17% 82.47% +0.30%
==========================================
Files 74 74
Lines 13367 13367
Branches 1977 1977
==========================================
+ Hits 10984 11025 +41
+ Misses 1713 1682 -31
+ Partials 670 660 -10 ☔ View full report in Codecov by Sentry. |
Replaced `ChunkerFixed`'s block-reading functionality with a new `FileReader` class to streamline code and improve separation of concerns. Adjusted `ChunkerFixed` to delegate file reading to `FileReader` while focusing on chunk assembly. `FileReader` is intended to be useful for other chunkers also, so they can easily implement sparse file reading / fmap support.
ThomasWaldmann
force-pushed
the
chunker-refactor
branch
from
e1a7f8c to
15f8115
Compare
Member
Author
|
superseded by #8883 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileReaderhas all the file reading code, including sparse/fmap and fadvise support, using a very similar API as the chunkersChunkerFixedworks (it is only a rather thin wrapper so the file reading blocksize ofFileReadercan be a multiple of the blocksize of theChunkerFixed)Chunkerrefactor and transformation to mostly Cython (3rd commit) broke it, why?