Skip to content

Comments

remove_dotdot_prefixes: remove bad assert, fixes #9406#9407

Merged
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
ThomasWaldmann:fix-filename-backslash
Feb 23, 2026
Merged

remove_dotdot_prefixes: remove bad assert, fixes #9406#9407
ThomasWaldmann merged 1 commit intoborgbackup:masterfrom
ThomasWaldmann:fix-filename-backslash

Conversation

@ThomasWaldmann
Copy link
Member

Description

remove bad assertion.

guess the assert was meant to make sure that we do not have backslashes as path separators, but did not consider that on linux a backslash can be part of a filename (without being a path separator).

Checklist

  • PR is against master (or maintenance branch if only applicable there)
  • New code has tests and docs where appropriate
  • Tests pass (run tox or the relevant test subset)
  • Commit messages are clean and reference related issues

guess the assert was meant to make sure that we do not have backslashes as path separators, but did not consider that on linux a backslash can be part of a filename (without being a path separator).
@ThomasWaldmann ThomasWaldmann merged commit 49959db into borgbackup:master Feb 23, 2026
17 checks passed
@ThomasWaldmann ThomasWaldmann deleted the fix-filename-backslash branch February 23, 2026 19:38
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.47%. Comparing base (4344eb3) to head (23f7388).
⚠️ Report is 8 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9407      +/-   ##
==========================================
- Coverage   76.47%   76.47%   -0.01%     
==========================================
  Files          85       85              
  Lines       14804    14803       -1     
  Branches     2213     2213              
==========================================
- Hits        11322    11321       -1     
  Misses       2803     2803              
  Partials      679      679              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant