legacy: extract LegacyArchives into legacy/archives.py, add ArchivesInterface, refs #9556#9639
Closed
mr-raj12 wants to merge 1 commit into
Closed
legacy: extract LegacyArchives into legacy/archives.py, add ArchivesInterface, refs #9556#9639mr-raj12 wants to merge 1 commit into
mr-raj12 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9639 +/- ##
==========================================
- Coverage 83.31% 82.97% -0.35%
==========================================
Files 89 90 +1
Lines 15549 15673 +124
Branches 2343 2374 +31
==========================================
+ Hits 12955 13005 +50
- Misses 1838 1889 +51
- Partials 756 779 +23 ☔ View full report in Codecov by Sentry. |
Member
|
This is a good first step for the archives list part of the Manifest. In a further step (not this PR) we could try whether we still need other parts of the Manifest or whether we could get rid of them. The main reason why this thing was called Manifest in borg 1.x (the manifest as a signed list of archives) is not in the manifest blob anymore in borg2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Borg 1.x archive list management out of
Archivesand intoLegacyArchives, refs #9556.LegacyArchivesextracted fromArchivesintolegacy/archives.pyArchivesinmanifest.pyis now 2.x only as allself.legacybranches removedArchivesInterfaceadded tomanifest.pyas a@runtime_checkableProtocol as mypy/pyright will catch drift between the two implementationsManifest.__init__picksLegacyArchivesorArchivesbased on repository type via lazy importsNo logic changes.
borg transfer --from-borg1keeps working throughborg.legacy.archives.borg servefor v1 clients is unaffected — it only opensLegacyRepositoryfor raw RPC byte-forwarding and never instantiatesLegacyArchives.Refs #9556
Checklist