fix: xattr xdg backup exclusion should be on 'false'#9666
Merged
ThomasWaldmann merged 1 commit intoMay 24, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9666 +/- ##
==========================================
+ Coverage 83.62% 83.75% +0.12%
==========================================
Files 90 90
Lines 15539 15539
Branches 2337 2337
==========================================
+ Hits 12995 13015 +20
+ Misses 1806 1789 -17
+ Partials 738 735 -3 ☔ View full report in Codecov by Sentry. |
Member
|
Ah, crap, clicked too fast... |
ThomasWaldmann
added a commit
that referenced
this pull request
May 25, 2026
ThomasWaldmann
added a commit
that referenced
this pull request
May 25, 2026
fixup for pr #9666: better variable name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the freedesktop proposal the xattrs attribute
user.xdg.robots.backupshould be set tofalseto exclude files from backups.The current implementation has it backwards, as files are excluded if
user.xdg.robots.backupis set totrue.Checklist
master(or maintenance branch if only applicable there)toxor the relevant test subset)