Skip to content

fix: xattr xdg backup exclusion should be on 'false'#9666

Merged
ThomasWaldmann merged 1 commit into
borgbackup:masterfrom
Flachz:fix-xattrs-xdg-backup-exclude
May 24, 2026
Merged

fix: xattr xdg backup exclusion should be on 'false'#9666
ThomasWaldmann merged 1 commit into
borgbackup:masterfrom
Flachz:fix-xattrs-xdg-backup-exclude

Conversation

@Flachz
Copy link
Copy Markdown
Contributor

@Flachz Flachz commented May 24, 2026

Description

According to the freedesktop proposal the xattrs attribute user.xdg.robots.backup should be set to false to exclude files from backups.

The current implementation has it backwards, as files are excluded if user.xdg.robots.backup is set to true.

Checklist

  • PR is against master (or maintenance branch if only applicable there)
  • New code has tests and docs where appropriate
  • Tests pass (run tox or the relevant test subset)
  • Commit messages are clean and reference related issues

Comment thread src/borg/archive.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.75%. Comparing base (fea52ef) to head (e19232b).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/borg/archive.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9666      +/-   ##
==========================================
+ Coverage   83.62%   83.75%   +0.12%     
==========================================
  Files          90       90              
  Lines       15539    15539              
  Branches     2337     2337              
==========================================
+ Hits        12995    13015      +20     
+ Misses       1806     1789      -17     
+ Partials      738      735       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit dd0713e into borgbackup:master May 24, 2026
19 of 20 checks passed
@ThomasWaldmann
Copy link
Copy Markdown
Member

ThomasWaldmann commented May 24, 2026

Ah, crap, clicked too fast...

#9667

ThomasWaldmann added a commit that referenced this pull request May 25, 2026
ThomasWaldmann added a commit that referenced this pull request May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants