legacy: move pbkdf2 static method from FlexiKey to Pbkdf2FileMixin#9668
Merged
ThomasWaldmann merged 1 commit intoMay 26, 2026
Merged
Conversation
mr-raj12
force-pushed
the
legacy-pbkdf2-into-mixin
branch
from
e421b7c to
d4f25ac
Compare
Member
|
Huh? "Workflow runs completed with no jobs" |
Contributor
Author
No ci triggered I tried with a commit too idk why? |
Member
|
Maybe too much vibe coding on github's side. :-) |
Member
|
Let's see if it runs CI for the merge... |
Member
|
There is some issue with fetching the CodeQL action code. Hopefully that will be resolved soon. |
Contributor
Author
Exactly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
pbkdf2fromFlexiKeyintoPbkdf2FileMixin. The last piece of PBKDF2 logic now lives entirely inborg.legacy, refs #9556.As in #9664 (comment), after #9665 dropped the KDF section from
benchmark_cmd.py, there was no reason forpbkdf2to stay onFlexiKey.pbkdf2static method moves fromFlexiKey(crypto/key.py) toPbkdf2FileMixin(legacy/crypto/key.py)pbkdf2_hmacimport removed fromcrypto/key.py, added tolegacy/crypto/key.pyFlexiKey.pbkdf2(...)→LegacyKeyfileKey.pbkdf2(...),FlexiKeyremoved from importNo logic changes. New key types (
CHPOKeyfileKey,AESOCBKeyfileKey, etc.) no longer carrypbkdf2as they never needed it.Refs #9556
Checklist