posixfs, s3, sftp: URL-unquote#131
Open
ThomasWaldmann wants to merge 2 commits intoborgbackup:masterfrom
Open
Conversation
Member
Author
|
@alexandru-bagu @mikemrm @ncw could you please review the URL-unquoting? Guess some unquote-calls were missing for S3 (and also for file: and sftp:), but for rclone: just pass-through "as is" is correct. |
Member
Author
URL components might be URL-quoted (URL-encoded), thus we need to unquote them if we split the URL into its components. For example, a space in a path would be encoded as %20. rclone is different: we get rclone:remote_spec and remote_spec is in the rclone-specific format that we just pass through "as is" to rclone.
ThomasWaldmann
force-pushed
the
url-unquote
branch
from
4859b74 to
500ab46
Compare
This was referenced Mar 6, 2026
| if m: | ||
| return Sftp(username=m["username"], hostname=m["hostname"], port=int(m["port"] or "0"), path=m["path"]) | ||
| return Sftp( | ||
| username=unquote(m["username"]) if m["username"] else m["username"], |
There was a problem hiding this comment.
Since (?P<username>[^@]+) always matches at least one character the m["username"] in the else case will always be None. Why not use None directly instead of failing to get the group again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL components might be URL-quoted (URL-encoded), thus we need to unquote them if we split the URL into its components.
For example, a space in a path would be encoded as %20.
rclone is different: we get rclone:remote_spec and remote_spec is in the rclone-specific format that we just pass through "as is" to rclone.