fix: add missing errorText label in ChangeBorgPassphraseWindow (#2372)#2479
Open
Denay2468 wants to merge 2 commits intoborgbase:masterfrom
Open
fix: add missing errorText label in ChangeBorgPassphraseWindow (#2372)#2479Denay2468 wants to merge 2 commits intoborgbase:masterfrom
Denay2468 wants to merge 2 commits intoborgbase:masterfrom
Conversation
Denay2468
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _set_status method referenced self.errorText but this widget was never created in init, causing an AttributeError when the change passphrase attempt failed.
Added errorText as a QLabel programmatically in init, styled in red and added to the form layout.
Related Issue:
Fixes #2372
Motivation and Context:
When a user’s passphrase change fails, Vorta crashes instead of showing an error message.
How Has This Been Tested?
∙ Ran existing unit tests: uv run pytest tests/unit/test_repo.py -v -k "passphrase" — all 3 passed
∙ Unable to fully test on Windows due to no Borg binary, but the fix is straightforward
Types of changes:
∙ ✅ Bug fix
Checklist:
∙ ✅ I have read the CONTRIBUTING guide
∙ ✅ My code follows the code style of this project
∙ ✅ All new and existing tests passed