Changes to get gtsam to compile in Windows #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I think all cmake changes are fine. However, I changed your PR so it's merged into a temporary branch
|
2 tasks
gchenfc
added a commit
that referenced
this pull request
Apr 12, 2021
bae34fac8 Merge pull request #82 from borglab/feature/templated-base-class 6fd4053dd Merge pull request #84 from borglab/feature/print_redirectstdout 349784a38 comment about redirecting stdout dc4fd9371 updated docs b43f7c6d7 Merge pull request #80 from borglab/feature/multiple_interface_files 7d8c3faa7 redirect std::out for print_() a812a6110 print redirect stdout unit test 97f3b6994 support for templated base class 3e16564e3 test cases for templated base class 7b9d080f5 Revert "unit test for printing with keyformatter" 45e203195 Revert "funcitonal print passes unit test" 8b5d66f03 Revert "include functional and iostream" 34bfbec21 Revert "delete debug statement" dbe661c93 Revert "add includes to the example tpl file." f47e23f1a Revert "Revert "function to concatenate multiple header files together"" e667e2095 Revert "function to concatenate multiple header files together" 600c77bf4 add includes to the example tpl file. d5caca20e delete debug statement 4a554edb8 include functional and iostream e8ad2c26f funcitonal print passes unit test 077d5c4e7 unit test for printing with keyformatter d5a1e6dff function to concatenate multiple header files together git-subtree-dir: wrap git-subtree-split: bae34fac828acb6b17bfe37ebe78f7c9a156ed5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were required on my Windows machine to get the gtsam library to compile. Using Boost 1.67, and VS 2017 (Community)
This change is