Add constructor for OptionalJacobian #884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixed-size version of
OptionalJacobian
doesn't have a constructor for pointers to dynamic matrices. This makes it cumbersome to deal with e.g.:Frank recommends using the former "modern" syntax but this isn't possible without adding the constructor overload:
OptionalJacobian(Eigen::MatrixXd* dynamic) {...}
For future readers who are less familiar, ternary operator must have same-types for the middle and last parameters, and since the last parameter is a null then the middle parameter (and the whole output-type) has to be a pointer type.
No breaking changes and nothing removed, just added a new constructor overload.