Conversation
This routine, given a pixel address on the screen in HL will set the ATTR for it. Also adds an extra entry point to the SET_ATTR routine. This routine is in charge of setting the ATTR upon an screen update operation (PRINT, PLOT, DRAW, CIRCLE). Now it can be used also by drawing primitives instead of the ROM's one.
BRIGHT 8 was not being set (transparent mode). Also BRIGHT 0 is now 0 and any other value is BRIGHT 1.
FLASH 8 was not being set (transparent mode). Also FLASH 0 is now 0 and any other value is FLASH 1.
This routine is not in ROM, and is centralised by all drawing and printing primitives.
This routine is not in ROM, and is centralised by all drawing and printing primitives.
boriel
added a commit
that referenced
this pull request
May 11, 2019
Bugfix bright 8 and flash 8 Approved-by: Jose Rodriguez <boriel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.