[Tests] Use exceptions for quitting from the emulation loop.#323
Merged
boriel merged 1 commit intoboriel-basic:masterfrom May 27, 2020
kosarev:use_exceptions_to_stop_emulation
Merged
[Tests] Use exceptions for quitting from the emulation loop.#323boriel merged 1 commit intoboriel-basic:masterfrom kosarev:use_exceptions_to_stop_emulation
boriel merged 1 commit intoboriel-basic:masterfrom
kosarev:use_exceptions_to_stop_emulation
Conversation
boriel
approved these changes
May 27, 2020
Collaborator
|
Good idea, thanks! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would help to resolve kosarev/zx#10 and make sure we don't even attempt to compare screenshots when the emulation is terminated due to reasons other than hitting the breakpoint, e.g., pressing
F10.