Skip to content

Feature/make warning muteable #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boriel merged 3 commits into from
Mar 13, 2022
Merged

Feature/make warning muteable #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19fb8ee
cleanup: fix comment typos
boriel Jan 23, 2022
00f593b
refact: use Enum value in zxbpp initalization
boriel Feb 20, 2022
8c9b7c7
feat: make while condition warning muteable
boriel Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/api/symboltable/scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Scope:

The caseins dict stores the symbol names in lowercase only if
the global OPTION ignore case is enabled (True). This is because
most BASIC dialects are case insensitive. 'caseins' will be used
most BASIC dialects are case-insensitive. 'caseins' will be used
as a fallback if the symbol name does not exists.

On init() the parent mangle can be stored. The mangle is a prefix
Expand All @@ -55,7 +55,7 @@ def __getitem__(self, key: str) -> Optional[SymbolVAR]:
def __setitem__(self, key: str, value: SymbolVAR):
assert isinstance(value, Symbol)
self.symbols[key] = value
if value.caseins: # Declared with case insensitive option?
if value.caseins: # Declared with case-insensitive option?
self.caseins[key.lower()] = value

def __delitem__(self, key: str):
Expand Down
2 changes: 1 addition & 1 deletion src/zxbc/zxbc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def main(args=None, emitter=None):
asm_output = "\n".join(asm_output)

# Now filter them against the preprocessor again
zxbpp.setMode("asm")
zxbpp.setMode(zxbpp.PreprocMode.ASM)
zxbpp.OUTPUT = ""
zxbpp.filter_(asm_output, filename=input_filename)

Expand Down
9 changes: 3 additions & 6 deletions src/zxbc/zxbparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import src.api.symboltable.symboltable
from src.api.debug import __DEBUG__ # analysis:ignore
from src.api.opcodestemps import OpcodesTemps
from src.api.errmsg import error
from src.api.errmsg import error, warning_condition_is_always
from src.api.errmsg import warning
from src.api.global_ import LoopInfo

Expand Down Expand Up @@ -1869,11 +1869,8 @@ def p_while_sentence(p):
gl.LOOPS.pop()
q = make_block(p[2], p[3])

if is_number(p[1]) and p[1].value:
if q is None:
warning(p[1].lineno, "Condition is always true and leads to an infinite loop.")
else:
warning(p[1].lineno, "Condition is always true and might lead to an infinite loop.")
if is_number(p[1]):
warning_condition_is_always(p.lineno(1), bool(p[1].value))

p[0] = make_sentence(p.lineno(1), "WHILE", p[1], q)

Expand Down