🚀 3.8.0 #183
Merged
🚀 3.8.0 #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removing horizontal lines from the logs. * Removing the plugin name from the log messages. * Updating the test. * Changeing the log levels of existing statements. * Updating the test. * Similar adjustments to migration scripts. * Updating the test. * Adding more debug-level messages. * Updating the test. * Minor adjustments to log messages of migrations. * Fix lint issue. * Update octoprint_octorelay/__init__.py * Update octoprint_octorelay/__init__.py * Apply suggestions from code review * Update octoprint_octorelay/__init__.py
* New event: TURNED_ON. * Draft for the implementation. * no migration * Updating test_get_settings_defaults. * Updating test_get_template_vars. * Mocking and asserting event handler call in test_handle_update_command. * Ref: moving the stetement into loop. * Same assertion for test_toggle_relay. * Ref: another condition for test_handle_update_command. * Ref: extracting assertion condition. * Updating snapshot. * Introducing the scope for handle_plugin_event. * Using the scope for TURNED_ON event. * Preventing infinite loop in handle_plugin_event for TURNED_ON and target True. * Replacing `return` with `continue` * Add branch logging * Introducing 'disabled' prop for UI events var structure. * Disabling the corresponding options in the template. * Updating snapshot. * Automatically highlight state label within event label. * Splitting statements. * Shortening syntax. * Shortening syntax. * Shortening syntax. * Private naming. * Revert "Private naming." This reverts commit 928031c. * Updating snapshot. * Add more cases to test_handle_plugin_event. * Fixed tests.
RobinTail
added
enhancement
Collaborator
Author
|
🚀 3.8.0rc1 Revealed: |
Collaborator
Author
|
Also, an obvious, but interesting thing to fix — the UI update can be triggered twice (by action and by polling). This is not related to the feature, but improved logging helped to reveal it. |
RobinTail
commented
Aug 16, 2023
Collaborator
Author
|
✅ QA passed |
Collaborator
Author
|
I figured out why this was happening: The iterable being iterated, so for being iterated again it has to be rewind. |
Collaborator
Author
|
Perhaps I could find how to organize this case better in the future: 
Maybe I could combine multiple upcoming events into a single popover |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27 and being and addition to #28
Closes #180