Conversation
* Upgrading all dependencies. * Upgrading Prettier and its helpers for ESLint. * Upgrading ESLint plugin for Typescript. * Adjusting package.json to the actual state.
* api can now accept "cmd":"off" or "cmd":"on" * added documentation and made changes as reqeuested * Revert "added documentation and made changes as reqeuested" This reverts commit 6f8d7a7. * Made changes and updated documentation * changing permissions. hopefully it sticks this time * added unit tests * Fixing trailing whitespace issues. * Fixing return statement issue: replacing with raising an Exception. * Updating the edge case test. * Minor: specifying the return type of toggle_relay() method. * Ref: removing unused statement. * Ref: ensuring the type of the target argument for handle_update_command() method. * Apply suggestions to README from code review * Readme: adjusting the documentation. * Readme: notice on target argument. * Removing redundant result from the fauly response payload. * Restoring the asserting on actual Relay::toggle() call. * Minor: fixing and explaining the test cases. * Handling possible exception of toggle_relay() method called by handle_update_command(). * Fixing the CodeQL warning. * Fixing the CodeQL warning (2). * Minor: message adjustment. * Testing the edge case. * Ref: minor, naming. * Readme: minor, grammar. --------- Co-authored-by: Anna Bocharova <robin_tail@me.com>
RobinTail
added
documentation
Collaborator
Author
|
🚀 3.12.0rc1 released, @patrickcollins12 |
Collaborator
Author
|
Regression test ✅ passed |
Collaborator
Author
|
The API command test ✅ passed |
RobinTail
commented
Oct 15, 2023
* Renaming images to have to dashes and underscores. * Moving illustrations outta quote
Collaborator
Author
|
OK. I will consider this as tested. In case you find any issues, please let me know, @patrickcollins12 , and we'll make a patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updatecommandtargetparameter #234