Merge all migration to uv and CI redesign work into 'dev'#377
Merged
boromir674 merged 111 commits intodevfrom Apr 8, 2025
Merged
Merge all migration to uv and CI redesign work into 'dev'#377boromir674 merged 111 commits intodevfrom
boromir674 merged 111 commits intodevfrom
Conversation
Owner
boromir674
commented
Apr 7, 2025
boromir674
commented
- add code comments on cicd Pipeline
- build: migrate pyproject.toml and lock to uv format
- build: enable poetry-core (aka masonry) as build-backend
- test: verify 'uv' and 'build module' frontends integration with poetry build backend
- emphemeral: make both 'uv'/'-m build' build --sdist compatible with build-backend include/exclude control for Distro build
- docs: update docs and add Dependencies Dev Notes page
- restructure tox.ini envs
- ci: deactivate test.yaml on push to migrate-to-uv branch
- ci: add ci.yml offering "Quick CI Feedback" on pushes (with exception for main, dev, release branches)
- ci: use --no-emit-flag uv flag to mirror poetry export behavior
- build: use hybrid pyproject blueprint; pass 'uv sdist File Structure' Testsgit add -p
- test: fix isort/black test on Biskotaki Gold snapshot
- build: allow 'pip install' to link entrypoint scripts git add pyproject.toml -p
- remove empty lines
- test: update tests, and apply aggressive black
- tests: update Biskotaki interactive snapshot to match non-intractive snapshot
- build: do uv.lock and commit lock file
- build: add build in test uv optional dependencies
- clean code
- tests: refactor
- tests: clean code
- ci: do not run tests marked as slow on CI Pipeline
- test: add unit tests for dics builder mapping
- ci: update CI Pipeline
- ci: better integration testing on CI Pipeline
- ci: fix
- ci: speed-up CI Pipeline with parallel Jobs for "unit" and "integration" tests
- ci: emphemeral: speed-up CI Pipeline by 'building env' only once! using CI Artifacts
- ci: probably pytest-xdist and running build module do not play along
- ci: isolate flaky tests
- test: reorganize functions"
- ci: adopt uv for env builds!
- ci: add Static Code Analysis reusable workflow and call it in CI Pipeline
- enable job
- ci: deactivate build job and build envs inside each unit/integration test Jobs: try to compare speed with previous builds
- ci: restore prod integration test settings
- ci: fix if conditions of sca job
- ci: fix sca-job
- ci: implement allow failure for sca-job.yml
- ci add sdist and wheel Test Ci Jobs
- ci: tes all_wheels building and test suite running
- ci: fix all_wheels Job
- test: skipping tests if no sources, better maintainability, WIP
- test: move data creation code to fixture from test
- test: make cookie context rendering tests invariant of sources availability
- test: make all tests invariant of tests running inside project or not
- ci: use pip wheels to for all_wheels Job
- ci fix type
- ci add test extras from pypi at runtime
- ci: add production settings to CI Pipeline
- ci: fix syntax quirks
- ci: fix syntax quirks
- build: migrate to uv the docslive deps extra
- update gitignore
- ci: migrate Test Job of test.yaml to uv
- ci: uv in CI/CD with reusable uv test matrix job
- reduce type checking errors
- refactor: src and test code to pass mypy
- build: install pytest in typing extra
- ci: clean code
- add trigger for 'pr to dev' to CI Pipe
- build: migrate the isort profile black
- refactor(isort): apply isort
- refactor(black): apply black
- lint tests wip
- refactor(isort): apply isort
- refactor(ruff): apply ruff
- refactor(black): apply black
- pass mypy
- ci: optimize ci.yml both for CI push events and 'PR to dev' events
- ci: exclude ci-redesign branch from test.yaml triggers
- update .gitignore
- test: update biskotakigold.cli expected rendered file
- ci: document Jobs triggers in code comments
- ci: emphemeral override some defaults of ci.yml trigger conditions
- pass string in matrix of ci.yml job
- ci: do not run slow tests because they depend on tox in matrix build test job
- use action to install uv oin windows for test matrix job of ci.yml
- install our package wheel in matrix test Job of ci.yml
- run 'installation command' in bash shell for windows CI ci.yml pipeline
- avoid a bug of 'uv run pytest' that installs a runtime built package even uninstalling it first if already installedgit add -p!
- prepare for iteratively debugin the ci.yml windows job test errors
- debug test_logging on windows ci.yml Job
- pass inconviently blocking env var required to "document windows bug", otherwise tests fail
- Revert "debug test_logging on windows ci.yml Job"
- revert ci.yml Job triggers to production code
- test: fix code to account for windows host
- Revert "revert ci.yml Job triggers to production code"
- debug context assertion with gold_standard case
- fix syntax on ci pytest invocation
- pass legacy flag PY_WHEEL required by test suite of running on windows host
- enable all patforms on ci.yml Job
- set to prod settings the ci.yml pipeline
Uv just offers a build-frontend (apart from fast dep management).
…uild-backend include/exclude control for Distro build
… for main, dev, release branches)
TODO: make black less aggressive
Run 'uv add --optional test build' and commit pyproject.tml and uv.lock
…ng CI Artifacts ci: fix, by wiring jobs ci: properly access the pytest entrypoint ci: try to only transfer the site-packages to/from CI Artifact ci: fix ci ci: fix ci ci: debug site-packages restoration from CI Artifacts ci: try download-ci action with pattern parameter ci: debug ci: debug 1 ci: put site-packages in proper place ci: add forgotten checkout step ci: fix CI Pipeline with sharable test env from Artifacts ! ci: fix integration tests Job of CI Pipeline ci: use --system flag ci debug
This reverts commit bbf9ba0.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bandit found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…ge/ci-upload workflow with uv
There was a problem hiding this comment.
Copilot reviewed 57 out of 62 changed files in this pull request and generated 3 comments.
Files not reviewed (5)
- docs/contents/20_why_this_package.rst: Language not supported
- docs/contents/35_development/dependencies.rst: Language not supported
- docs/contents/35_development/index.rst: Language not supported
- scripts/update-snapshot-interactive.sh: Language not supported
- scripts/update-snapshot.sh: Language not supported
|
|
||
| Returns: | ||
| GivenInterpreters: dictionary with intepreters as a sequence of strings, | ||
| t.Mapping[str, t.Sequence[str]]: dictionary with intepreters as a sequence of strings, |
There was a problem hiding this comment.
Typo in comment: 'intepreters' should be 'interpreters'.
Suggested change
| t.Mapping[str, t.Sequence[str]]: dictionary with intepreters as a sequence of strings, | |
| t.Mapping[str, t.Sequence[str]]: dictionary with interpreters as a sequence of strings, |
Comment on lines
+73
to
+74
| if [[ "${{ matrix.platform }}" == "windows-latest" ]]; then | ||
| . .venv/Scripts/activate |
There was a problem hiding this comment.
The workflow uses '${{ matrix.platform }}' although no matrix is defined; replace it with '${{ inputs.platform }}' to correctly reference the input value.
Suggested change
| if [[ "${{ matrix.platform }}" == "windows-latest" ]]; then | |
| . .venv/Scripts/activate | |
| if [[ "${{ inputs.platform }}" == "windows-latest" ]]; then |
Comment on lines
+91
to
+92
| if [[ "${{ matrix.platform }}" == "windows-latest" ]]; then | ||
| . .venv/Scripts/activate |
There was a problem hiding this comment.
This conditional again uses '${{ matrix.platform }}' despite the absence of a defined matrix; use '${{ inputs.platform }}' instead to ensure proper platform checking.
Suggested change
| if [[ "${{ matrix.platform }}" == "windows-latest" ]]; then | |
| . .venv/Scripts/activate | |
| if [[ "${{ inputs.platform }}" == "windows-latest" ]]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.