Skip to content

feat: add no expiration offers #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
albertfolch-redeemeum merged 15 commits into from
Nov 8, 2023
Merged

feat: add no expiration offers #900

albertfolch-redeemeum merged 15 commits into from
Nov 8, 2023

Conversation

@albertfolch-redeemeum
Copy link
Contributor

@albertfolch-redeemeum albertfolch-redeemeum commented Oct 27, 2023 •
edited
Loading

  • change offer validation period & redemption period inputs on the seller side
  • change detail widget to show redemption from/for
  • disable redeem button if exchange is not valid
  • restore time & timezone in offer & redemption periods if you go back
  • change copies offer validation period & redemption period (seller side)
  • add x button to clear date (if prop is enabled)

@albertfolch-redeemeum albertfolch-redeemeum linked an issue Oct 27, 2023 that may be closed by this pull request
dApp - Default to no expiration date on offers #886
Closed
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 27, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49ba0a0
Status: ✅  Deploy successful!
Preview URL: https://0a411a50.interface-a9d.pages.dev
Branch Preview URL: https://886-dapp-default-to-no-expir.interface-a9d.pages.dev

View logs

@albertfolch-redeemeum albertfolch-redeemeum marked this pull request as ready for review October 31, 2023 16:39
@albertfolch-redeemeum albertfolch-redeemeum requested a review from a team as a code owner October 31, 2023 16:39
@albertfolch-redeemeum albertfolch-redeemeum merged commit 6ce1388 into main Nov 8, 2023
@albertfolch-redeemeum albertfolch-redeemeum deleted the 886-dapp-default-to-no-expiration-date-on-offers branch November 8, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@levalleux-ludo levalleux-ludo levalleux-ludo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dApp - Default to no expiration date on offers

3 participants

@albertfolch-redeemeum @levalleux-ludo