Implement markers #217
Merged
Implement markers #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yves Bastide <yves@botify.com>
-D, -W. Signed-off-by: Yves Bastide <yves@botify.com>
* marker.Marker(name, details)
* task.MarkerTask(name, details)
* workflow.record_marker(name, details=None)
-> return self.executor.record_marker(name, details)
* workflow.list_markers()
-> return self.executor.list_markers()
* abstract methods in the base executor
Signed-off-by: Yves Bastide <yves@botify.com>
Also add an example. Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Contributor
Author
|
(missing tests...) |
Add an option to show all the values of the markers, not just the last one. Signed-off-by: Yves Bastide <yves@botify.com>
Contributor
Author
|
^ damn, started to add tests but forgot to implement them... |
Signed-off-by: Yves Bastide <yves@botify.com>
This simplifies the simpleflow.swf.executor.Executor#submit casts. Signed-off-by: Yves Bastide <yves@botify.com>
ampelmann
reviewed
Feb 24, 2017
| def wait_signal(self, name): | ||
| return self.executor.wait_signal(name) | ||
|
|
||
| def record_marker(self, name, details=None): |
Member
There was a problem hiding this comment.
Why not a serializable object for details ?
Contributor
Author
There was a problem hiding this comment.
Yep, this should be better.
Don't expect a string for `record_marker`'s `details` argument; instead,
serialize it and unserialize in `list_markers`.
* json_dumps/json.loads
* add serializers to _serialize_complex_object:
* datetime.date
* datetime.time
* uuid.UUID
* update test
Signed-off-by: Yves Bastide <yves@botify.com>
The "+00:00" TZ was expected by some tests; we now replace it with "Z". Oops. Signed-off-by: Yves Bastide <yves@botify.com>
jbbarth
reviewed
Feb 24, 2017
| self.details = details | ||
|
|
||
| def __repr__(self): | ||
| return '<{klass} {name!r} details={details!r}>'.format( |
Collaborator
There was a problem hiding this comment.
Didn't know the conversion flags, nice! :)
simpleflow/swf/executor.py
Outdated
| )) | ||
| self.after_replay() | ||
| self.decref_workflow() | ||
| if self._append_timer and not self._timer_scheduled: |
Collaborator
There was a problem hiding this comment.
self._timer_scheduled seems to not be used anymore in current code?
Contributor
Author
There was a problem hiding this comment.
Totally unused, it's for some future timer PR 🙂
I'll add an explanation
Contributor
Author
There was a problem hiding this comment.
... No, better remove it
| def wait_signal(self, name): | ||
| return self.executor.wait_signal(name) | ||
|
|
||
| def record_marker(self, name, details=None): |
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Based on a comment by @ampelmann. Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Try to load a string; if this fails, return the string itself. Useful when the callee doesn't return a JSON-formatted result... Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Signed-off-by: Yves Bastide <yves@botify.com>
Collaborator
|
👍 ; needs more work before merging @ybastide ? |
Contributor
Author
|
Nope (well, we'll have to discuss #222 later): let's merge and release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #216