Fix GroupBox border for Firefox#39
Merged
botoxparty merged 1 commit intobotoxparty:mainfrom Oct 18, 2021
Merged
Conversation
Firefox's new WebRender engine seems to have a bug with fieldsets styled with inset box-shadows (https://bugzilla.mozilla.org/show_bug.cgi?id=1496538). As a workaround, use a tiny .SVG as a sliced border-image to draw the border.
Owner
|
Sorry for such a long delay on this! Thank you for your contribution 🥰 |
Contributor
Author
|
No problem at all, thanks for merging! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a similar PR to jdan/98.css#117 which fixes GroupBox rendering for Firefox with the Windows 98 theme.
It also appears to fix an accuracy issue under Chromium.
Before
After:
Windows 98 reference screenshot: